Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Icosa integration #710

Draft
wants to merge 162 commits into
base: main
Choose a base branch
from
Draft

Icosa integration #710

wants to merge 162 commits into from

Conversation

andybak
Copy link
Contributor

@andybak andybak commented May 5, 2024

In parallel with the work happening on https://github.com/icosa-foundation/gallery-api/tree/feature/jhr-dev this branch has the matching changes for Open Brush. Currently:

  1. Login/authentication via device codes
  2. Sketch upload similar to previous Google Poly upload

…after submit (was still double triggering for some reason)
…tion

# Conflicts:
#	Assets/Settings/Localization/Strings/Strings Shared Data.asset
andybak and others added 30 commits November 23, 2024 16:05
This is a quick initial fix; Not ready for merge yet

This fixes one major issue with the feature. Previously, you couldn't break apart a GLTF model more than once, as it would just create duplicates of the thing you were trying to break apart

I don't know if the feature works for all cases of GLTF transform hierarchies
Previously, the method continued iterating even after a valid children was found

This simple change makes it stop as soon as the first valid child is found
This commit improves developer experience as the original node name is kept visible, and the UID is appended to the end

[CI BUILD DEV] [CI BUILD]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Feature added
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants